Skip to content

fix(skills): raise registry card Install button above navigation overlay#2098

Merged
samuv merged 1 commit intomainfrom
install-button
Apr 24, 2026
Merged

fix(skills): raise registry card Install button above navigation overlay#2098
samuv merged 1 commit intomainfrom
install-button

Conversation

@samuv
Copy link
Copy Markdown
Collaborator

@samuv samuv commented Apr 23, 2026

On the Skills > Registry tab, clicking Install on a card would navigate to the skill detail page instead of opening the install dialog. The Local Builds and Installed tabs were unaffected.

Root cause

card-skill-base.tsx renders a full-card click overlay — an absolutely-positioned <span> pinned to inset-0 inside the title button — to make the whole card a navigation target. Because the overlay is absolutely positioned against the relative Card, it stacks above any statically-positioned descendant, including footer buttons. Siblings in the footer have to opt into their own stacking context (position: relative + a z-index) to receive their own clicks, otherwise the overlay captures the pointer and the card-level onClick runs instead.

Every other action button in the Skills cards already does this:

The Install button in card-registry-skill.tsx was the only one missing the escape hatch, so the overlay kept eating its clicks. The existing e.stopPropagation() on the handler was correct but never fired — the event never reached the button in the first place.

Changes

  • card-registry-skill.tsx: add relative z-10 to the Install button's class list, matching the pattern used on the other Skills cards.

No logic, analytics, or markup changes beyond the class tweak.

Verification

  • On Skills > Registry (both grid and table views), clicking Install opens the install dialog. Clicking the title or any empty area of the card still navigates to the skill detail page.
  • Local Builds and Installed tabs behave as before.
  • Existing tests in card-registry-skill.test.tsxopens the install dialog when Install button is clicked and does not navigate when Install button is clicked — continue to pass; they exercise the onClick path via userEvent and are unaffected by the z-index fix.

Copilot AI review requested due to automatic review settings April 23, 2026 17:31
@samuv samuv self-assigned this Apr 23, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes an interaction bug in the Skills “Registry” tab where the card-level navigation overlay was intercepting clicks intended for the Install button, preventing the install dialog from opening.

Changes:

  • Raise the Registry card Install button above the full-card navigation overlay by adding relative z-10 to its class list.

@samuv samuv merged commit a76f62e into main Apr 24, 2026
21 checks passed
@samuv samuv deleted the install-button branch April 24, 2026 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants